> I took a look and this looks good so far and a bit simpler than what I > thought would be necessary but I haven't tried to test it yet. >
Please test if you have time. It was a long time ago for me too that I worked on that code. > I do remember that someone commented that they didn't like the use of > > boost::uint32_t > > and that (IIRC) just using an unsigned int with an assertion about its size > should be fine. Yes, I read that Andre mentioned this as a personal preference. Well, if he still feels this should be changed, he will shout again ;). Besides we use boost::uint32_t in more places in the code, so if anyone changes this, please change it everywhere. Besides that, we use more datatypes from boost: boost::int32_t, boost::crc_32_type. I think there are people that want to get rid of boost in the end, but then all these datatypes should be replaced. > > The other thing was that my original patch used a Map somewhere in > BufferParams to map author onto the hash value. How do you get around that > since I think you have a Vector? I still have a map in BufferParams.h: /// map of the file's author IDs to AuthorList indexes std::map<unsigned int, int> author_map; Vincent
