Question regarding "New from template..."

[Stephan Witt]

I'm trying to go for ticket #6861 http://www.lyx.org/trac/ticket/6861 ...

Now I'm wondering about the implementation of

static FileName selectTemplateFile()
{
        FileDialog dlg(qt_("Select template file"));
        dlg.setButton1(qt_("Documents|#o#O"), toqstr(lyxrc.document_path));
        dlg.setButton1(qt_("Templates|#T#t"), toqstr(lyxrc.template_path));

        FileDialog::Result result = dlg.open(toqstr(lyxrc.template_path),
                                 QStringList(qt_("LyX Documents (*.lyx)")));

        if (result.first == FileDialog::Later)
                return FileName();
        if (result.second.isEmpty())
                return FileName();
        return FileName(fromqstr(result.second));
}

The two calls to setButton1() look really strange.

Why does nobody care here? If I assume the 2nd call should be setButton2...
Is it of any use to provide lyxrc.template_path twice? 
Once in the sidebar and again in the presetted path?
I'd expect lyxrc.template_path in Button1 and sys-template-path in Button2.

Stephan