On 20/09/2010 5:16 PM, Pavel Sanda wrote:
Julien Rioux wrote:
-       if (!pconverter_){
-               if (b.params().encoding().package() == Encoding::japanese)
-                       pconverter_ = setConverter("lyxpreview-platex");
-               else
-                       pconverter_ = setConverter("lyxpreview");
-       }
+       if (b.bufferFormat() == "lilypond-book")
+               pconverter_ = setConverter("lyxpreview-lytex");
+       else if (b.params().encoding().package() == Encoding::japanese)
+               pconverter_ = setConverter("lyxpreview-platex");
+       else
+               pconverter_ = setConverter("lyxpreview");

why the test on (!pconverter_) is no more needed?


The "lytex" converter adds an extra preprocessing step through lilypond-book, which converts .lytex > .tex. We don't want this for every single buffer, but only for the buffers using the lilypond module.

Correct me if I am wrong, but it seems to me that the current situation in trunk is to create a pconverter and stick to it for the remainder of the session. That's why I removed the check on the pconverter, to make this decision on a per buffer basis.

also, one needs lytex to have lilipond usable?
this patch had to be done inside lytex project and diffed against it,
thus unusable here.

--- lib/scripts/lyxpreview-lytex2bitmap.py      (revision 35036)

this file does not exists in lyx proper...
there are many other links to lytex in your patch, so before diving in, please 
send
updated version...


I did
svn cp lib/scripts/lyxpreview2bitmap.py lib/scripts/lyxpreview-lytex2bitmap.py

and started modification from there. The patch is what I get from
svn diff > my.patch

Please let me know how else I should provide a patch in this case.

pavel


--
Julien

Reply via email to