Pavel Sanda wrote:
> 
>> +    case LFUN_BUFFER_WRITE_ENCRYPTED:
>> +            enable = doc_buffer;
> 
> here should be something like
> ifndef encryption
> lfun.setflags(off);
> #endif
> 
> which will remove it from menu, so you dont have to care about 
> commenting/uncommenting
> line in menu.ui file.

Yes, much better than touching the ui file.


>> +    FileName filename = decryptedFileName(filenameIn);
>> +
> 
> i wonder what happen if lyx2lyx comes to such file.

Only a decrypted temporary file. But I have the feeling the way of opening
a file is not finished.

> 
>> +            case LFUN_BUFFER_WRITE_ENCRYPTED:
>> +                    LASSERT(doc_buffer, break);
>> +                    saveBufferEncrypted(*doc_buffer);
>> +                    break;
>> +
> 
> one problem might be that user can think that its saves also all related 
> stuff around,
> just think about all the tmp files.figs etc. this can be solved by warning 
> with
> 'don't show again' check box.

Do we have a function to pack all needed files into one zip file in the 
meantime?
I only could remember there were long discussions on the list.
Then we could pack before.

> 
> also he could think that opening encrypted file means that new save is 
> encypted
> by default. should we change the extension?

Saving again encrypted could be added, but then we must buffer the pwd or the
dialog pops up again.

> 
> if its question of just one routine we could include it and get rid
> of openssh dependence...
> 

Don't know how isolated the openssl code is. And there is another function which
generates the key from the pwd.

Peter

Reply via email to