Richard Heck wrote: > On 04/08/2010 04:25 PM, Pavel Sanda wrote: >> for...@lyx.org wrote: >> >>> Author: forenr >>> Date: Thu Apr 8 22:22:20 2010 >>> New Revision: 34095 >>> URL: http://www.lyx.org/trac/changeset/34095 >>> >>> Log: >>> Use cheaper conversion method. >>> >>> Modified: >>> lyx-devel/trunk/src/Buffer.cpp >>> >>> Modified: lyx-devel/trunk/src/Buffer.cpp >>> ============================================================================== >>> --- lyx-devel/trunk/src/Buffer.cpp Thu Apr 8 16:35:25 2010 (r34094) >>> +++ lyx-devel/trunk/src/Buffer.cpp Thu Apr 8 22:22:20 2010 (r34095) >>> @@ -673,10 +673,10 @@ >>> params().isfontcolor = false; >>> params().notefontcolor = lyx::rgbFromHexName("#cccccc"); >>> lyx::dispatch(FuncRequest(LFUN_SET_COLOR, >>> - from_utf8("greyedouttext #cccccc"))); >>> + from_ascii("greyedouttext #cccccc"))); >>> params().boxbgcolor = lyx::rgbFromHexName("#ff0000"); >>> lyx::dispatch(FuncRequest(LFUN_SET_COLOR, >>> - from_utf8("shaded #ff0000"))); >>> + from_ascii("shaded #ff0000"))); >>> >> i know nothing about the issue but dispatch inside Buffer::readHeader >> looks >> like dirty hack. >> >> > Indeed, that looks dangerous. This should probably be done after the > document has been read. > > Can someone explain why we need this dispatch here?
i guess you are asking for r34086 pavel
