On 04/07/2010 09:08 AM, Jean-Marc Lasgouttes wrote:
rgh...@lyx.org writes:
Author: rgheck
Date: Wed Apr 7 14:41:19 2010
New Revision: 34072
URL: http://www.lyx.org/trac/changeset/34072
Log:
The lv variable was used back in LyXView.cpp, where we didn't have such
easy access to the current view. So we don't need it. Moreover, it seems
to me that using lv in some of these places could cause bugs. What if
the current_view_ has changed? Then we could be updating completion on
the wrong thing?
Are you sure of what happens when a buffer is open or closed, for
example? I had bugs in the past where I opened an undo group on what
buffer, and then closed it on a different one after the dispatch. I
guess this cannot happen here, but you have to be sure about these kind
of scenarios.
Actually, this is the kind of thing I was wondering about. But then, if
the buffer is closed, can't the old lv become invalid? That's the other
thing I was wondering about.
I can revert if the old devil seems nicer than the new one.
rh
