Vincent van Ravesteijn - TNW wrote: >>> Moreover, it would be nice if one can set the GNUWIN32_DIR variable >>> within the user interface of Cmake. This is now not possible. Only the >>> GNUWIN32_DIR_tmp variable is visible in the gui. >> I've committed a patch. Should work now. >> > > Thanks. > > Next chance for improvement: The iconv.dll is not found automatically while > it is in my dependency directory. Strangely the ICONV_DLL_HELP variable is > found: > > ICONV_DLL ICONV_DLL-NOTFOUND > ICONV_DLL_HELP D:/.../lyx-devel-deps/bin/iconv.dll > ICONV_INCLUDE_DIR D:/.../lyx-devel-deps/include > ICONV_LIBRARY D:/.../lyx-devel-deps/lib/iconv.lib > > The Cmake error message is: > > Cmake Error at modules/FindICONV.cmake:65(message): > exit cmake > Call Stack (most recent call first): > CMakeLists.txt:454 (find_package) > > I don't understand what this ICONV_DLL_HELP is about (why do we search for > iconv.dll twice, once with no default path and once with one) and why the > following if is in the FindICONV.cmake file:
'find_file(ICONV_DLL': This ensures iconv.dll is in the scope of your PATH variable, because it must also be found at runtime, not only when building lyx. So, while searching for ICONV_DLL_ all cmake specific search pathes are ignored: NO_DEFAULT_PATH But yes, for building ICONV_DLL_HELP is superfluous and having only ICONV_LIBRARY should be enough. ICONV_DLL_HELP is only good for writing the path to iconv.dll in the error message. Peter > > if(NOT ICONV_DLL AND ICONV_DLL_HELP) > exit > end > > Vincent >
