On 03/18/2010 09:43 PM, rgheck wrote:
Investigation of #6454 revealed that we are blinking the cursor even
when it is off screen, causing recalculations of paragraph metrics,
which may have weird side effects---such as #6454. Can someone please
stop the cursor from blinking when it isn't on the screen? At least
most of the time? I know nothing about this sort of thing.
This seems to do it. Anyone know a reason not to do this check here?
Index: /cvs/lyx-devel/trunk/src/frontends/qt4/GuiWorkArea.cpp
===================================================================
--- /cvs/lyx-devel/trunk/src/frontends/qt4/GuiWorkArea.cpp (revision
33803)
+++ /cvs/lyx-devel/trunk/src/frontends/qt4/GuiWorkArea.cpp (working copy)
@@ -396,6 +396,12 @@
void GuiWorkArea::startBlinkingCursor()
{
+ Point p;
+ int h = 0;
+ buffer_view_->cursorPosAndHeight(p, h);
+ if (!buffer_view_->cursorInView(p, h))
+ return;
+
showCursor();
//we're not supposed to cache this value.
