Vincent van Ravesteijn wrote: >> >> Author: sanda >> Date: Mon Feb 22 03:01:04 2010 >> New Revision: 33533 >> URL: http://www.lyx.org/trac/changeset/33533 >> >> + Compare * compare = new Compare(loadIfNeeded(FileName(f1)), >> loadIfNeeded(FileName(f2)), dest, options); >> + compare->start(QThread::LowPriority); >> + sleep(2); >> + lyx::dispatch(FuncRequest(LFUN_BUFFER_SWITCH, >> dest->absFileName())); >> > I think we should call the dialog from here.
my idea was this: - one icon for comparison with last revision. this is to be used only as a quick check, so any additional dialog to be avoided. for this there would be needed some flag inside comparison code to call LFUN_BUFFER_SWITCH at the end of computation. the current sleep() was just dirty hack and seeing problems on Win i will just revert the whole thing. - one icon for general comparison. gui not implemented yet but i was thinking about dialog which let you choice the revisions, maybe shows the commit history. once selected it would just call guicompare dialog with already checkouted temporary files with the correct revisions. > This now crashes. sory not here. i will revert it, the sleep only caused troubles anyway. pavel
