sa...@lyx.org schreef:
Author: sanda
Date: Mon Feb 15 08:10:59 2010
New Revision: 33474
URL: http://www.lyx.org/trac/changeset/33474


-bool SVN::prepareFileRevision(int rev, string & f)
+bool SVN::prepareFileRevision(string const & revis, string & f)
 {
+       if (!isStrInt(revis))
+               return false;
+
+       int rev = convert<int>(revis);
        if (rev <= 0)
                if (!getFileRevisionInfo())
                        return false;

Why do you need the revision number for revision 0 ? Doesn't svn cat output the latest commit by default without a revision number.

This now kills the possibility of using TortoiseSVN, although you can call

doVCCommand("echo $WCREV$ > " + tempfile + " && SubWCRev " + path + " " + tempfile + " " + tempfile, FileName(owner_->filePath()));

By the way, why don't we make the svn commands customizable. I don't like all these hardcoded commands in the code, that won't let you use another app.

Vincent

Reply via email to