Vincent van Ravesteijn - TNW wrote:
Author: younes
Date: Sun Sep 27 12:29:13 2009
New Revision: 31472
URL: http://www.lyx.org/trac/changeset/31472
Log:
Transfer LFUN_INSET_APPLY from GuiView to BufferView.
The list of dialog edited inset is now stored in BufferView.
Before this commit, dialogs that were connected to an Inset were
automatically closed when the buffer with this Inset was closed. Now,
this doesn't happen anymore.
This is intended. Dialog disappearing automagically are bad. The correct
behaviour is to disable dialog when the inset is disconnected.
This code, for example,
InsetBox::~InsetBox()
{
hideDialogs("box", this);
}
is thus broken, as with the closed buffer, the list of dialogs<->insets
is also lost.
As I said, an inset has no business in dialog. Emitting a signal like
Buffer::insetDeleted() would be fine though. In the case of InsetBox, I
suspect that its dialog is indeed broken.
Abdel.
