>> I agree on the fix in general, it's just that the condition strikes me >> as if it was put there intentionally in order to prevent some specific >> behaviour (other than just updating the dialog). >> > >Or this framework was just a big pile of bugs and I just didn't know >what to do with these tests at the time... IOW Vincent is most probably >correct :-) >
I felt like it was put there for some reason, so I searched through the svn history to find out when and where it was introduced. However, the code was moved a few times around and it seems that this specific line was there forever. After this I've been breaking my head to find a reason for it being there, but I couldn't find it. And... I don't like code that I don't understand, so it had to go :).. IOW I hope I'm right. Vincent
