Abdelrazak Younes wrote:
> On 19/12/2009 12:43, Peter Kümmel wrote:
>>> I implemented that approach now in trunk. But by cloning the Buffer as
>>> this was the cleanest approach and less intrusive approach. It works
>>> well except for the lack of feedback on the background processing.
>>>
>>> Abdel.
>>>      
>> Great, if it works we could remove
>> QCoreApplication::processEvents(QEventLoop::AllEvents);
>> in Systemcall.cpp which is responsible for several crashes.
>>    
> 
> How is this related?

We don't need the explizit processing of GUI events any more because
the buffer processing does not block the GUI any more.


> 
>> But atm nothing happens when I press the "View" button in the toolbar.
>>    
> 
> This toolbar item seems broken currently but I don't think this is 
> related to my commit. Menu -> view or update (pdflatex or dvi) works 
> fine here (as well as Ctrl+D or T)
> 
>> Any places where I could help?
>>    
> 
> Yes, if you have time there are two things:
> 
> 1) Replace all call to Alert::warning() related to some Buffer action 
> with a new Buffer::warning() method that will use the GuiDelegate to 
> send the warning to the GUI even when we are in another thread. This is 
> because new widget cannot be created from another thread so we must 
> implement a signal from the thread that will ask the main thread to 
> launch the dialog.
> 
> 2) Use the same signal/slot mechanism for Buffer::message().
> 
> Abdel.
> 

Reply via email to