On 11/11/2009 08:30 PM, Uwe Stöhr wrote:
rgheck schrieb:
These two patches take different approaches to solving the same
problem. Alex's is correct, so I am committing it to trunk, too.
This solution didn't work on Windows, see my email in the actual
configure.py thread.
And your solution doesn't work on anything except Windows. See Alex's
bug report:
http://www.lyx.org/trac/ticket/6317
and the attached patch. That was the patch I applied. It wasn't mine.
Obviously.
Pavel, as he said, accidentally committed it to branch, too, but it
is OK.
No it is not. What we have now in branch doesn't work. The correct
solution is http://www.lyx.org/trac/changeset/31949.
Well, you and Alex need to figure out what works on which platforms,
test it appropriately, and then bring a patch that sorts out all the
various issues. Having you correct the bug one way in trunk and him
correct it another way in branch is madness. The way Alex did it also
fixes the problem Pavel reported, as he noted on the list, but breaks
Windows, right? The way you did it fixes the bug on Windows but leaves
Linux broken, and probably Mac as well.
I would suggest that you revert to status quo before r31949, and then we
can apply a patch that works when we have one. Same for branch, perhaps.
rh
