On 11/02/2009 01:24 AM, Vincent van Ravesteijn - TNW wrote:
I would like to share with you three patches.
-- One removes superfluous tags from the stdinsets file.

This is fine, I think.

-- Bug 6113: Customized font color in footnote is not rendered in LyX
It seems we're realizing the fonts in the wrong order.
http://www.lyx.org/trac/ticket/6113

I don't know much about realizing, but I seem to remember there were problems here at some point. So I'd check to make sure this hasn't broken anything else.

-- Bug 5657:Font not displayed correctly in editor for Box (minipage)

If an Inset can't be in a font change command (i.e. if noFontChange() is true), the default buffer font was used. In the LyXCode example, we use \normalfont\ttfamily to specify the font. In that case, even insets that return true for noFontChange() do have the typewriter font. So, therefore I use the layout-font for those Insets. In combination with the default to inherit the font, this will solve the bug.

A problem now is that for a Float inset, it goes wrong because it doesn't care about the layout. But, this indicates that it is nonsense for a Float inset to be part of a paragraph in LyX.

A second problem is a Table in a LyX-code paragraph in a Footnote. The text in the table is then rendered as Roman, while it should be typewriter.

Anyone thinks that the patch is on the right track ?

I'm not at all sure here, but I think that it is probably OK to have inherit_font as the default font for InsetLayout, rather than sane_font. This can always be modified in the InsetLayout declaration. I don't really know about the rest.

rh

Reply via email to