you...@lyx.org wrote:
> Author: younes
> Date: Mon Sep 21 10:21:37 2009
> New Revision: 31427
> URL: http://www.lyx.org/trac/changeset/31427
> 
> Log:
> Fix crash with LFUN_PARAGRAPH_GOTO in embedded work area.
> 
> Modified:
>    lyx-devel/trunk/src/BufferView.cpp
> 
> Modified: lyx-devel/trunk/src/BufferView.cpp
> ==============================================================================
> --- lyx-devel/trunk/src/BufferView.cpp        Mon Sep 21 10:20:02 2009        
> (r31426)
> +++ lyx-devel/trunk/src/BufferView.cpp        Mon Sep 21 10:21:37 2009        
> (r31427)
> @@ -1256,6 +1256,8 @@
>       }
>  
>       case LFUN_PARAGRAPH_GOTO: {
> +             if (buffer_.isInternal())
> +                     return false;
>               int const id = convert<int>(cmd.getArg(0));
>               int const pos = convert<int>(cmd.getArg(1));
>               int i = 0;

what about at least putting some FIXME to all these cases?
there will be another 100 more crashes elsewhere just because of this
buffer_.isInternal thingie. it should be really treated in a general
way if we were not able to save buffer_ for non internal only.

pavel

Reply via email to