Enrico Forestieri wrote:
On Sun, Sep 06, 2009 at 11:10:25PM +0200, Andre Poenitz wrote:
On Sun, Sep 06, 2009 at 05:50:28PM +0000, Enrico Forestieri wrote:
Andre Poenitz writes:
On Sun, Sep 06, 2009 at 05:36:44PM +0200, Enrico Forestieri wrote:
The attached patch implements the LyX server for Windows in 1.6.x.
Can anybody remind me why we need to use 500+ platform specific
lines code of our own instead of using, say, QLocalSocket?
Because QLocalSocket::socketDescriptor() is not going to work
with QSocketNotifier?
Wouldn't we just connect to QLocalSocket::readyRead() or such?
QLocalSocket requires Qt >= 4.4
Windows packages (including cygwin AFAIK?) deliver with Qt4.5 ;-)
Honestly, I was also uneasy about this platform specific code but I
didn't say anything because 1) you obviously spent quite some work on it
and 2) nobody else volunteered to implement the feature on Windows
before you 3) your code is quite clean (even though nobody else in the
list than you understands it) 4) it exists now.
Abdel.
