On Thu, Aug 13, 2009 at 12:27:17AM +0200, Uwe Stöhr wrote: > The attached patch switches from \newcommand to \providecommand for all > LyX-specific command definitions. (For some efinitons we already use > \providecomand.) It turned out that \newcommand definition could break > TeX-LyX roundtrips when the user modifies the TeX file, see the recent > tex2lyx discussion. > > The patch will go in when nobody objects.
With \providecommand an old macro definition remains in effect, even if it is defined differently. So you have to be sure that that is the right thing to do, otherwise you are exchanging an easy revealed error with obscure bugs, maybe difficult to spot or even going unnoticed. So, I am firmly objecting, indeed. Rather, teach tex2lyx how to do the right thing. -- Enrico
