Abdelrazak Younes schreef:
On 10/08/2009 23:10, Abdelrazak Younes wrote:
On 10/08/2009 23:03, Vincent van Ravesteijn wrote:
Abdelrazak Younes schreef:
On 10/08/2009 22:57, Vincent van Ravesteijn wrote:
you...@lyx.org schreef:
Author: younes
Date: Mon Aug 10 22:54:22 2009
New Revision: 30970
URL: http://www.lyx.org/trac/changeset/30970
Log:
Move the inline spellchecking code from collectWords() to the row
drawing routine. The text row is spell checked only if changed!
Now inline SpellChecker is faster than ever. Now, I honestly
think that we blow out all the competitors (thunderbird, OO,
MSWord, etc) :-)
SpellChecking in the RowPainter code ?
Against your religion?
Abdel.
Let's do updateLabels in the rowPainter, and updateMacros, and
setBuffer ?
Let's be a little bit pragmatic here:
1) Even if this is not obvious, this spellckecker code has something
to do with drawing: the purpose is precisely to draw spellchecking
marks.
2) There is absolutely no need to draw spellchecking marks outside of
the visible text area
3) There is no need to redo spellchecking if the row contents did not
change
4) the row painting code is the *only* place where we check if the
contents has changed.
That being said, if you have any clever or cleaner idea, I am all ears
:-)
Abdel.
Don't you need to check only the word that has just finished being
edited and other changes made to the text. The rest only once when it is
shown for the first time. Now each word is checked trillion times over
and over again.
Are the spellcheck dictionaries in the memory ? I hope that I would not
have to read from disk everytime.
Vincent
