On 09/08/2009 21:33, Vincent van Ravesteijn wrote:

Nothing. But updateLabels() do a whole lot more than just updating the labels.
, which indicates that we have been misusing the updateLabels for a long time.

So, I would rather start cleaning up this mess rather than hiding this by renaming the function.

Hum, I guess you don't get it. The reason why we do a lot of things in updateLabels() is that we do not want to go through the entire Buffer structure more than once; because this is demanding for big documents.

When you think more about it, updating a label in a particular inset is just a special case with regards to Buffer realization. In the case of a cross reference for example we don't want to just update its label, we also want to update the reference cache at the same time. So this 'misusing' was not an afterthought, it was very intentional and I wanted to change the function name since a long time now that I remember...

Abdel.

Reply via email to