On Tue, 14 Jul 2009 15:47:25 +0200 Jean-Marc Lasgouttes <lasgout...@lyx.org> wrote:
> Le 14 juil. 09 à 15:32, lasgout...@lyx.org a écrit : > > + // FIXME this use of forceLTR is dubious > > + // introduced in http://www.lyx.org/trac/changeset/21285 > > + if (getLayout().isForceLtr()) { > > + // Force any new text to latex_language FIXME: This > > + // should only be necessary in constructor, but new > > + // paragraphs that are created by pressing enter at > > + // the start of an existing paragraph get the buffer > > + // language and not latex_language, so we take this > > + // brute force approach. > > + cur.current_font.setLanguage(latex_language); > > + cur.real_current_font.setLanguage(latex_language); > > + } > > + > > I have copied the code above from InsetCollapsable, but I do not > understand the logic. > forceLTR is defined as: > /// Force inset into LTR environment if surroundings are RTL? > virtual bool forceLTR() const; > > I suspect the right thing to use is getLayout().isPassthru. > > Martin, do you remember why you chose that instead? > > JMarc No... but as the comment says, it is probably overkill. - Martin
