Abdelrazak Younes <you...@lyx.org> writes: > Jean-Marc Lasgouttes wrote: >> It is interesting to note that, since the version requirements have been >> set to 4.2.2 in 1.6.0, nobody felt the urge to remove the 6 #ifdef that >> are now useless. So much for the argument that a specifying a version >> allows to simplify the code :) >> > > I just checked and indeed there are #ifdef for 4.2.2 but I thougth the > requirement was 4.2.0...
pegase: grep -r QT_VERSION .|grep 0402 ./GuiDocument.cpp:#if QT_VERSION >= 0x040200 ./GuiView.cpp:#if (QT_VERSION >= 0x040202) ./GuiView.cpp:#if (QT_VERSION >= 0x040202) ./GuiView.cpp:#if (QT_VERSION >= 0x040202) ./GuiPrefs.cpp:#if QT_VERSION >= 0x040200 ./GuiCharacter.cpp:#if QT_VERSION >= 0x040200 ./FileDialog.cpp:#if QT_VERSION != 0x040203 I see: 3 for 4.2.0, 3 for 4.2.2 and one for 4.2.3. Our requirement is/was 4.2.2. JMarc
