On Wed, Jul 1, 2009 at 6:40 AM, Jean-Marc Lasgouttes<lasgout...@lyx.org> wrote:
> First incident remark: use
>      known = !qkey_to_string(key_).empty();
> instead.

Thank you.  I don't yet know proper C++ syntax, so I will do these
silly things while I learn.

> What I would like is to drop the "Unknown function part" and only test
> on isKnown. Could you test whether this suffices?

Hmm, how about this:
  http://www.lyx.org/trac/attachment/ticket/6043/multimediakeys4.diff
In summary, I abandoned isKnown, and just redefined isOK with
  -   bool const ok = !(text_.empty() && key_ == Qt::Key_unknown);
  +   bool const ok = !(text_.empty() && qkey_to_string(key_).empty());
Consequently, multimedia keys are immediately discarded, so there's no
"Unknown function."  Is this the behavior you want?

-Ben

Reply via email to