> Overall the xforms stuff is looking very nice. I took at peek at the
> gnome and kde stuff as a result of the change to update and
> updateBufferDependent. There seems to be an aweful lot of code just to
> get things running with gnome.
True! There are two reasons for it. First, I decided to code some dialogs
and then compose the base classes looking into the implementation of
several dialogs. This approach helped me to learn LyX and its requirements
to compose base classes better. Second, all the dialogs which use "action"
area have to be constructed on "fly" and change/update on the basis of
user input. This makes using the dialogs easier, faster and much more
fun, but coding ... well, you mentioned a size of the code :).
> There's also a few connections being made to update that aren't used
> (since update is empty) is this a temporary thing? (ie. do you plan on
> filling in some more code?)
Most (even it seems to me that all) of these empty update functions are in
"action" area dialogs. My latest patch connects updateBufferDependent to
hide function. The reasons for it are as follows.
If I understand correctly "update" is called when user opens a new
document or changes the document. If this is true then for "action" area
dialogs the update signal has to close the dialog since user is not
interested in this action anymore :). At least it is easier to implement
than keeping action area state for each document...
> There also appears to be a few places where a new update_something()
> function exists that could be used as update() and an update connection
> would then make sense.
the quick grep for update in gnome sources showed only updateButtons in
FormCitation that might look as a candidate for an update connection and
which doesn't use it. However, updateButtons is used to track user input
in FormCitation dialog and has nothing to do with change of the document.
> Marko is there any particular reason for using NULL instead of 0 in a lot
> of your code? Is this a gnome convention? Where is it defined?
I am just used to call NULL a pointer that might lead to a core dump. I
haven't looked into gnome conventions recently, but if you will give me a
good reason to use integer 0 insted of NULL then I can change
everywhere NULL to this particular integer value.
> BTW, I've said it before but I'll say it again anyway since it's friday:
> You don't have to call your files by the same name as the xforms code.
> I would have expected KDE for example to use DialogXxxxx myself -- or
> whatever naming convention exists for apps using a particular toolkit.
Unfortunately, the gnome frontend is still lagging behind xforms. That's
why it is easier to use the same names for the dialogs since it gives a
good overview of the state of the port. Finally, it is nice to remember
roots of LyX when everyone will switch to Gnomified version :).
[...]
> There that's probably pissed nearly all the GUII devvies off.
No way! It is very nice to have someone who is looking into the code. It
is a first step to make this effort in porting LyX to gnome or kde from
one-man project to dynamic project full of
discussions/suggestions/implementations as the rest of LyX is. Actually,
this is a reason why I would not like to have cvs-write access anytime
soon. This guarantees that the code was working at least in two occasions
and someone has at least just scanned the patch.
> Have a nice Friday 13th,
Enjoy it too.
Marko
