On Sun, Jun 21, 2009 at 07:38:15PM -0400, Ben M. wrote: > Hi everyone, > > I wrote my first patch, which works simultaneously in branch and > trunk. It implements inverse search in a child document. > http://www.lyx.org/trac/attachment/ticket/6020/revdvichild.diff > > I wonder if people approve, and if so, if someone can commit this for me.
In your patch you are iterating over all buffers and not only those that actually are children. So, if you have two different masters including the same child, it could happen that the wrong buffer is selected. I admit that it is not so likely, but it is better to account for that, so I applied a better patch that avoids this problem: http://www.lyx.org/trac/changeset/30214 -- Enrico
