Pavel Sanda schreef:
v...@lyx.org wrote:
Author: vfr
Date: Mon May 4 13:53:34 2009
New Revision: 29532
URL: http://www.lyx.org/trac/changeset/29532
Log:
Aesthetics: Hide the tabbar when closing all windows one-by-one
duh. this cant work.
I feel stupid ;-)
when you have ten files opened and few of them are edited, then
cancel of saving will let the tabbar in hidden state.
Thanks, I oversaw that.
iirc the code below was somehow engaged in hiddening/showing toggle of
fullscreen mode,
but i havent tested if something gets broken.
I don't think this is involved in anything that has to do with
fullscreen, and fullscreen still works flawlessly.
generally i would be more happy if you let this code as it were then fixing the
problems above
and complicating the code.
Fixing the problems you mention above, just means calling
"showBar(true)" before the return calls. I don't feel that that will
very much complicate a function that already consists of 108 lines, in
which happens way too much, which triples some code and which has some
mid-air return calls.
(in fact i even dont find the previous state disturbing...)
Well, I made it somewhat more disturbing by always closing the first tab
while fixing bug #5001 in r29530. After this change, the tabbar looks a
bit buggy with a missing first tab. That's why I decided to hide the
tabbar, and it's not really needed anymore.
pavel
To please you, I can either, leave it as it was (which looks buggy to
me), or close the tabs in a reverse way and then complicating the way
the session file is written or read (also in reverse), or add the calls
to show the bar again after cancelling.
Do others have an opinion ?
Vincent
