Jürgen Spitzmüller schreef:
Enrico Forestieri wrote:
Jürgen, OK for branch?

Without this patch it is a pain working with child documents.
In some cases, when I have finished quickly typing 5 or 6 characters,
only the first two have been shown on screen.

Is this the slowness issue we have been reported about shortly after the 1.6.2 release?
Yes, but the problem has been there since the first release of the 1.6 cycle.
I'm all for fixing this issue in branch (It's a mustfix, IMHO). However, I would be a bit more confident if someone on win32 (maybe someone who faced the slowness problems) tested this a bit more thoroughly.

There are serious problems with this commit.

If I open a document (using webdav) that has a child document, I can't open the child document. Moreover, opening the child manually will give me a warning that it already is open. After opening this child, the master document has disappeared from LyX.

Looking at the commit, the change looks kind of rude. All the special cases that are handled in operator==() and the refreshing and so forth, are thrown overboard. Besides that, Qt is totally passed by.

And what about the patch from Georg ? That patch sort of solved the problem too. This patch was less intrusive and I already tested that.

If it was upto me, I would revert this commit and commit Georg's patch.

Vincent

Reply via email to