Vincent van Ravesteijn wrote:

     ///
     bool closeBuffer(Buffer & buf, bool tolastopened = false);
+    enum NextOrPrevious {
+        NEXTBUFFER,
+        PREVBUFFER
+    };
+    ///
+    void gotoNextOrPreviousBuffer(NextOrPrevious np);

Again some questions about enumerations from me....

First, last time you used capitalized lowercase names, now they are uppercase ?

Well, I don't know there's a definite convention here. InsetCode.h does all caps, as do several other enums, and then there are the ones that do something else. Maybe we should settle on something and write a really good sed script to fix it all. Or ask Andre to do it. ;-)

Second, if both members of the enumeration have the term Buffer in their names, then I'd guess you could use the term in the name of the enumeration and leave it from the members ...

Then it would be clear in the function declarations, but not necessarily where its used. I'd just as soon waste a few source characters for clear self-documentation.

rh


Reply via email to