On Mon, 2 Oct 2000, Angus Leeming wrote:
> Attached are 3 patches
>
> patch-insets cleans up the use of Buffer * by InsetBibtex and InsetInclude
>
> patch-redundant removes some functions/variables from mathed that are
> declared but not used. The result of compiling extra-picky!
haven't looked at these.
> patch-xforms cleans up the frontend/xforms directory in some small ways.
applied this one and a couple of other minor changes.
I'm wondering if we should remove all those "virtual"s I added in the
classes derived from FormBase since they are declared private in the
derived classes whereas they are protected in FormBase. We don't want to
derive from the derived classes (apart from perhaps FormCommand) so we
shouldn't need the "virtual" unless the picky compiler complains. But the
picky compiler is more likely to complain about taking a protected
function private I think. I only added the virtual tags in the first place
so I could keep track of which stuff I had cleaned up.
Anyone got a comment?
Lars? (a.k.a. oh great C++ guru)
Allan. (ARRae)
