Manoj Rajagopalan wrote: > Attaching the patch that creates a "Case insensitive" checkbox. This box is > enabled only if the sort checkbox has been checked. Also, > case-insensitivity state is persistent across enable/disable cycles so it > needn't be rechecked each time it becomes enabled when checking Sort.
looks good. some comments below. we also need your stating your contributions are made under GPL-2, eg http://marc.info/?l=lyx-devel&m=122469079629276 > +inline bool caseInsensitiveLessThan(const QString &s1, const QString &s2) > +{ > + return s1.toLower() < s2.toLower(); > +} maybe locale-aware sorting could be done > + /// sort case-insensitive or not persistent state > + bool caseInsensitive_; this should be case_insensitive_ pavel
