>>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:

Angus> What it does do: * The block-if statement in Buffer::readInset
Angus> is rearranged to minimise bloat. All those occurences of
par-> InsertInset(pos, inset, font);
Angus>          ++pos; reduced to only one.

A somewhat different approach would have been to define a
readInset(Inset*) method 

void readInset(Inset* inset) {
  inset->Read(this, lex)
  par->InsertInset(pos, inset, font);
  ++pos;
}

and use it as:

if (tmptok == "Quotes") {
  readInset(new InsetQuotes);
} else
...

I am not sure it is better, your patch just got me thinking...

JMarc

Reply via email to