Lots of feedback. Cheers!
JMarc> I thought we were supposed to be waiting for NEW_INSETS before
JMarc> creating new collapsable stuff.
Jürgen> Yes I'm also of the opinion we should now freeze the code for NEW
Jürgen> stuff! What we should still accept is GUII (porting of EXISTING
Jürgen> dialogs to the frontend directory) AND obviously BUG-fixes!
fine by me! I'll put InsetNote on hold.
Allan> It would be nice if Painter could be extended to support the drawing
Allan> of 3d buttons with different coloured backgrounds so we could keep
Allan> the bright yellow of Notes. This should simply involve passing one
Allan> colour and the colour of the bevels is calculated from this
Allan> (hue+saturation interpolation for example or use the features
Allan> of a given toolkit).
Good idea. This too can wait.
Angus> Finally, I have made the xforms implementation of FormCopyright a
Angus> derived class of FormBase and demonstrated that none of these
Angus> FormXXX classes need be dependent on Dialogs.h if they are
Angus> passed pointers to the relevant show, hide and update signals
Angus> directly by Dialogs.C.
Allan> I don't like the looks of this much at all...
All fair comment. I was, however, merely trying to demonstrate that it's
possible to have one base class that does all this rather nasty stuff. I was
thinking last night that the production code would merely need a flag
definining whether the browser was invariant across all buffers and therefore
needed a hideAll signal, or was buffer dependent and therefore required the
hideBufferDependent, updateBufferDependent signals. Same idea as your's for
the form property mask.
Allan> Anytime someone decides to add an extra signal for a dialog they
Allan> have to change Dialogs.C and FormXxxx.[Ch] instead of just
Allan> FormXxxx.C (assuming the signal exists or Dialogs.h also if the
Allan> signal doesn't).
Again, good point. As I was saying, I was just playing! With reflection, the
present interface is clean and simple. Think of this submission as a
work-in-progress, evolving thought experiment!
IF I can make a neat, elegant interface to FormBase, then I definitely think
we gain. The resultant daughter classes are immeasurably simpler. Have you
seen FormCopyright??? Anyway, I'll press ahead and show you my vision!
Angus
