Stephan Witt wrote:
> Ok, I'll apply rcs.txt this evening. And yes it fixes an aspect of bug 5389
> only. Maybe an unrelated issue in fact. The first from_utf8 in patch is
> obvious as the input value provided by the caller is from LyX and utf8
> coded. The second is only slightly better then from_ascii. The function
> SVN::scanLogFile is completely character set agnostic. So the returned
> string can be of any character set, as I understand it. There should be
> something done about encoding too.

Does it depend on the locale? Then from_local8bit might be more appropriate.

> The original crash recipe in bug 5389 following I didn't get a crash with
> current LyX1.6.1svn. (Besides the encoding one.) Maybe it is fixed, I'll
> double check this evening again. The difficulties I have are caused by the
> different SDKs I have to use for development and for package building. This
> situation I have to solve soon.
>
> I forgot to mention my change 27627. It fixes a memory leak on Mac OS X.
> This is a candidate for backport too.

If you're really confident with it and it's well tested, then OK.

Jürgen

Reply via email to