Vincent van Ravesteijn <[EMAIL PROTECTED]> writes:
> Is anybody willing to review and/or try this patch ?
The biggest problem I have with this is that, since you add the suspend
flag automatically, the mechanism is very fragile. What if you copy the
second enumeration in front of the other? What if the last element of
the list is removed? All these actions will likely give us a broken file.
A few other comments (besides those from Richard and Juergen, which I +1).
> +void ParagraphParameters::resumeEnumeration(bool resume)
> +{
> + resume_enumeration_ = resume;
> +}
> +
> +
> +bool ParagraphParameters::resumeEnumeration() const
> +{
> + return resume_enumeration_;
> +}
Would it make sense to have a single enumerationStatus() enum for these
two things (and also in file format)?
> +pit_type Text::getFirstParInEnv(Cursor const & cur, pit_type pit_) const
Did you look at those functions in paragraph_funcx.cpp?
/// for the environments
pit_type depthHook(pit_type par,
ParagraphList const & plist, depth_type depth);
pit_type outerHook(pit_type par, ParagraphList const & plist);
You should either use them or, if they are not good enough, add your new
functions in this file with similar naming and calling conventions.
JMarc
