On Wed, Nov 19, 2008 at 08:59:17PM +0100, Vincent van Ravesteijn wrote: > Dov Feldstern schreef: >> >> 1) boundary should not be set to true at a (intra-paragraph) line >> break; fixes >> this: >> >> abc|\n -> move right -> abc\n (and not: abc\n| >> FED FED| FED ) >> >> 2) boundary should not be set (even if left_font is provided) at pos == 0; >> fixes this: >> >> abc\n -> toggle to RTL -> abc\n (and not: abc\n| >> | | ) >> > > Hi Dov, > > The second example you give here is quite a special case. In this case, > there a three possible locations. At the upper row after \n, at the > lower row in the R-part and at the lower row in the L-part. I think that > this shows that we it is not enough to have a single boundary member. > > I would suggest that we introduce two members: row_boundary and > rtl_boundary. I personally feel that the boundary is a little bit > misused to represent two different boundaries. If we add a second > boundary member, I think that this is solved much more easily, and the > code will be better understandable. Besides, the third patch you > supplied is then no longer needed (I hope). > > What do you think of this proposal ?
Sounds good. I was always confused by the different meanings of the boundary. Andre'
