Pavel Sanda wrote:
Hello Tommaso,
we have agreed that it would be good to merge search branch into trunk,
so the work continue there. For the proper merge we need review the
current patch bit by bit.
The complete diff for advsearch branch is attached.
The FindAdv manual can go in as is for now, but it should of course be
merged into the main manuals once things have settled down.
One other minor thought:
diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index 314631c..fd4b676 100644
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -1809,10 +1820,6 @@ int BufferView::workHeight() const
void BufferView::setCursor(DocIterator const & dit)
{
- size_t const n = dit.depth();
- for (size_t i = 0; i < n; ++i)
- dit[i].inset().edit(d->cursor_, true);
-
d->cursor_.setCursor(dit);
d->cursor_.setSelection(false);
}
This looks dangerous. Is it required?
rh
