On 08/11/2008 17:53, Tommaso Cucinotta wrote:
Hi,
with the attached patch for the lyx-advsearch branch:
- The GuiView tracks the currentMainWorkArea()
Why is this distinction between normal and embedded work areas needed?
- there is a visual highlight of the current main wa through a thick
border; feel
free to customize if you think it looks like ugly;
- now Esc, Enter and Shift+Enter are correctly intercepted by the
container dialog
by installing an eventFilter
- Search Buffer is added to theBufferList() like other buffers, so it
is destroyed
on program exit
Good.
- SearchWA is not destroyed by the GuiView::closeEvent() loop, but by its
own container, i.e., in the dialog destructor
GuiSearchAdv::~GuiSearchAdv()
- I couldn't find a way to crash it, but I didn't play too much
finding all the
nested possible things close to borders or inset begins/ends etc...
- I really could not understand why the search workarea is focused in
then
immediately focused out when opening the dialog via C-S-f;
for now, the correct focus may be obtained in various ways:
Because the focus automatically returns to the current work area after a
dispatch. As you now make the distinction between normal and embedded
work areas, the focus goes back to the main one.
- C-S-f, then click the search wa
- C-S-f, then Tab
- C-S-f, then Alt-Tab twice
- when the dialog opens up, the searchworkarea contents is again selected
entirely, so starting to type whatever (after a Tab for gaining
focus) deletes
the last search text
Try to set the cursor selection to false on open up
(bufferView().cursor().setSelection() or something like that).
- there is also a little focus issue when closing the program with
unsaved
changed buffer: the dialog asking if I want to save is not focused;
IIRC from your patches, there's a number of changes in your branch that
are not necessary and are perhaps causing issues.
however,
this is an issue in regular trunk as well. Specifically:
- if I close via menu, then it is focused.
- if I close via Alt+F4 (Ubuntu/Gnome) or via the close `X' button on
the top-right
- window corner, then it is unfocused.
Add this to bugzilla please.
I hope Abdel has some clue on how to fix the focus issue (I read he's
the Gui man).
I am not alone (I hope) but I am quite busy these days so I cannot help
you much more than that, sorry. I hope though that you don't loose
motivation, users (including me) are waiting for this feature.
Abdel.
