Abdelrazak Younes wrote:
On 20/10/2008 17:48, José Matos wrote:
On Friday 17 October 2008 12:39:28 rgheck wrote:
So I think this really is needed, and it has to go in before 1.6 or
wait
for 1.7, since it is a (layout) format change.
Comments welcome.
I have understood the rationale for the change (I hope) and I agree with
changes. If this is to go in 1.6 I would like to see it in before rc4.
OTHO I would like to have feedback from other developers.
The rationale for putting this in seems quite clear and the patch is
essentially additional, mostly clean, code. I just have some
cosmetic/semantic comments:
1) "defaultmodule" -> "requiresmodule" and similars. Or maybe I didn't
understood the code too well.
It's not obvious what to do here. The module isn't really required: the
user can remove it. It's just one that's loaded by default unless the
user removes it.
2) locale variable are lower_case (provMods -> prov_mods or
provided_modules)
OK.
3) I prefer less criptic members (exclmod_ -> excluded_modules_)
OK!
rh
