I noticed that the errorlist (for chktex in this case) does not work at
all like I intended. When I click on the items one by one, the
description that appears does not match what I want. Instrumenting
GuiErrorList::select() with lyxerr shows that the index used by this
function does not match what I click.

After looking at what the converter selection code in prefs does, I came
up with the following simple patch, which hooks on the currentRowChanged
signal instead of itemSelectionChanged. It works perfectly for me (qt
4.2.3).

However, before committing, I'd like to know: what is the difference
between these two signals? There are other places relying on
itemSelectionChanged, shall I fix them?

JMarc

svndiff src/frontends/qt4/GuiErrorList.cpp

Index: src/frontends/qt4/GuiErrorList.cpp
===================================================================
--- src/frontends/qt4/GuiErrorList.cpp	(revision 26510)
+++ src/frontends/qt4/GuiErrorList.cpp	(working copy)
@@ -41,7 +41,7 @@ GuiErrorList::GuiErrorList(GuiView & lv)
 
 	connect(closePB, SIGNAL(clicked()),
 		this, SLOT(slotClose()));
-	connect(errorsLW, SIGNAL(itemSelectionChanged()),
+	connect(errorsLW, SIGNAL(currentRowChanged(int)),
 		this, SLOT(select()));
 
 	bc().setPolicy(ButtonPolicy::OkCancelPolicy);

Reply via email to