> Vincent van Ravesteijn <[EMAIL PROTECTED]> writes: > > I have processed your comments. I also removed als Change::UNCHANGED
> > and friends from the code. I had to work with objects after all, due > > to the Change::color function. If you like it, we might change it in > > other parts of the code. > > What s the status of the patch (wrt change_running initialization, > in particular)? I like it in general, although I am not sure we need > so many accessors for Change. OTOH, I do not know which one should be > removed :) > Jmarc The status is that I was awaiting your comments and I'm refreshing my C++ OO knowledge a bit. It seems I just can replace these two initializations by "Change change_running;" and everything is OK. It sounded like you wanted to make the Change::Type enum sort of private. In that case I'm afraid we need all those accessors, although some of the set*** functions are not used at the moment (in this patch). Nevertheless, I think we could add them, so we can gradually remove all Change::Type friends from the code sometime, if this is still what you want. So, if you don't have any more comments, then I'll change the two initializations and send you a new patch this evening. Vincent
