Vincent van Ravesteijn wrote:
Abdelrazak Younes wrote:
Yes, that sounds a better and cleaner solution. We basically only keep
rows that are shown on screen in memory so adding two move variable is
not a big problem.
Abdel.
Hi,
I sort of cut the new code in four. It is no longer computed for and
after the checksum and the code is generalized for both the begin as
end margin. Besides it is mostly transferred into Row, so the
drawParagraph function is now as clean as it used to be.
Thanks for that patch, I like it much better than the previous one. Just
one nitpick:
+void Row::setEndMarginSelection(bool const end_margin) const
We typically don't use const when passing POD data so that should be:
+void Row::setEndMarginSelection(bool end_margin) const
I'll make this change and commit.
Thanks,
Abdel.
