rgheck wrote:
Vincent van Ravesteijn - TNW wrote:
Hi all,

While trying to fulfill my bug-solving quota of this week, I came accross the following :

Almost all methods in the GuiPainter class have something like

if (!isDrawingEnabled())
  return;

except GuiPainter::fillRectangle(...) !!

Adding this will solve

*gmane.editors.lyx.devel/109857* <http://article.gmane.org/gmane.editors.lyx.devel/109857> *gmane.editors.lyx.devel/109859* <http://article.gmane.org/gmane.editors.lyx.devel/109859>
*http://bugzilla.lyx.org/show_bug.cgi?id=4937*
http://bugzilla.lyx.org/show_bug.cgi?id=5027
*http://bugzilla.lyx.org/show_bug.cgi?id=5235* <http://bugzilla.lyx.org/show_bug.cgi?id=5235>

Maybe also:
http://bugzilla.lyx.org/show_bug.cgi?id=5230

How odd! We'd all been thinking the problem was a missing redraw. But apparently not.


He he, that's because a rectangle drawing overwrites everything that is within the triangle, good catch Vincent!



Anyway, Abdel or someone who really knows this stuff should give a go on this.

I'll commit it.


By the way, your patches are for some reason not appearing as text in my mail reader. Not sure why.

Same here. That's because the attachment is mime encoded or something like that.


If you haven't already, bug JMarc for commit privileges. Still always a good idea to post things for comment, unless they are very trivial. But at least then you can commit things yourself.

I vote for letting Vincent get commit privileges :-)

Abdel.

Reply via email to