Jean-Marc Lasgouttes wrote: > "Vincent van Ravesteijn - TNW" <[EMAIL PROTECTED]> writes: > > 1. Texts that are entered in the search and replace fields of the > > GuiSearch dialog are added to the bottom of the ComboBox. With this > > patch they are added to the top as it probably most intuitive. > > Looks good to me (unless someone else has a reason for this behaviour).
Agreed. > > 2. The GuiRef dialog does not respond to keyboard events if the > > reference list is empty. This is because the reference list has the > > focus proxy and is disabled when the list is empty. Therefore I removed > > the focus proxy from the list if it is disabled. > > Don't know. Sensible IMHO. I committed both patches. > > 3. The Listings inset is always painted on its own line, even when it is > > collapsed. Is this a design decision ? I changed this such that when it > > is collapsed, the button is painted inline. > > If the listing is always in display mode in the text (breaks the > paragraph flow), then it should be that way on screen. I think so, too. Jürgen
