Pavel Sanda wrote:
[EMAIL PROTECTED] wrote:
Author: sanda
Date: Tue Jul 22 02:04:03 2008
New Revision: 25781

+/*!
+ * \var lyx::FuncCode lyx::LFUN_VC_REVERT
+ * \li Action: Reverts the document to the last check-in/commit in VCS.
+ * \li Syntax: vc-revert
+ * \li Origin: Lgb, 1 Jul 1997
+ * \endvar
+ */
                { LFUN_VC_REVERT, "vc-revert", ReadOnly, System },

while reviewing the code of LFUN_VC_REVERT of CVS i came to a very strange 
construction:

doVCCommand("rm -f " + fil + "; cvs update " + fil,...

2 question to windows herd:
1. does "rm -f" works in windows?

I'm not even sure "rm" is known under Windows, let alone "-f", though I could be wrong. But independent of the answer to this question, you should probably split this into a call to FileName::removeFile() and then the call to cvs update. That makes the first part as platform-neutral as possible. Of course, the latter bit won't be.

rh

Reply via email to