Dekel,

Concerning the changes you did in Converter::setViewer() to quote
$$FName. I do not think these changes were needed. The best is
probably to use QuoteName() on the file name later, as in:

        string command2 = subst(command, "$$FName", 
                                QuoteName(OnlyFilename(filename)));

The advantage of QuoteName is that it does nothing for OS/2 (where
'quoting' is not well understood by the shell) and could be adapted
later to provide a better quoting mechanism.

JMarc

Reply via email to