On Thu, May 29, 2008 at 10:08:46AM +0200, Stefan Schimanski wrote: > > Am 28.05.2008 um 22:41 schrieb rgheck: > >> >> This code in MathMacroTemplate.cpp has to be wrong: >> case LFUN_IN_MATHMACROTEMPLATE: >> flag.enabled(); >> break; >> That READS the flag, pointlessly. It doesn't write it. Maybe what's wanted >> is flag.enabled(true)? > > Yes, that would make more sense. > > Btw, calling the method enabled(bool) is a bad choice. Why not > setEnabled(bool)? Then those mistakes would be obvious.
Right. There was a time when a different naming convention was used. The bug you ran into here is exactly the reason why I believe that the old convention has its limitations... Andre'
