Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> Jean-Marc Lasgouttes wrote:
>> Abdelrazak Younes <[EMAIL PROTECTED]> writes:
>>
>>>> Looks OK. The names of the enum values could be shorter, maybe
>>>> (ASTR_NONE...).
>>>>
>>> Then they are not meaningful. I'll change that to AS_STR as a compromise.
>>>
>>
>> OK.
>>
>>
>>>> And didn't we agree they should be lowercase?
>>>>
>>>>
>>> Not really. We agreed that the enum type should be as all other types
>>> but that enum value should stay uppercase (see FontEnums.h). We should
>>> probably uniformize all this...
>>>
>>
>> In Rules, I see:
>>
>> * Enumerators
>> enum {
>> one = 1,
>> two = 2,
>> three = 3
>> };
>> -NOT-
>> enum { one = 1, two = 2, three 3 }; // wrong
>> -NOT-
>> enum {
>> ONE = 1,
>> TWO = 2,
>> THREE = 3
>> };
>>
>> I do not say I care much about it, but we should be consistent with
>> new enums.
>>
> Well, all lowercase can be confused with variables so this is out for
> me, I'll change the Rules file.
> All uppercase has the advantage to be clearly identifiable even if the
> confusion with macros is possible.
> Qt uses the same convention as for types: CamelBump, I'd be OK with that
> personally.
I'd prefer a separate convention... but I do not care much as I said.
JMarc
