Also sprach Helge Hafting:
> No, I wrote that similiar to how dotfill and hrulefill gets reverted.
> I should have asked about this:

The problem was that the InsetSpace syntax was changed after the 
dortfill/hrulefill implementation. So, in contrary to that one, you have to 
revert from
\begin_inset Space \leftarrowfill{}
\end_inset

not from the former

\InsetSpace \leftarrowfill{}

> When using my patched lyx, the arrowfill revert will not get tested,
> because this LyX supports arrowfills. When using a previous LyX,
> a revert does not happen because that LyX don't have the revert stuff.
>
> Clearly, something have to be copied to the older LyX for a useable
> test, but what? The lyx_1_6.py file? The .pyc? The entire lyx2lyx
> directory?

I usually test as follows:

1. Create test document in LyX 1.6
2. File -> Export -> Custom ...
3. Choose "LyX 1.5.0" as export format and "lyx $$FName" as command
(where "lyx" is LyX 1.5)

That's it. (one of the many cases where the custom export dialog proves to be 
useful)

> > I rewrote that and committed.
>
> Thanks, that saves another iteration! I'll try to remember testing
> lyx2lyx the next time I add to the file format. It might be useful to
> allow a length specification for the various non-blank fills.
> A user might want a 5cm dotfill, for example. The latex way
> is to put the fill in a 5cm parbox, but doing that explicitly in LyX
> looks overly complicated. The hspace dialog have a length specification
> after all - simply don't disable it when selecting a fill and the user
> can do this in a nice and easy way.  I'll look at that after cleaning
> up the main window graphichs - unless there is opposition to the idea.

Yes, there are several potential improvements.

> > BTW I see the following messages in console when inserting a hspace:
> >
> > Lexer.cpp(909): Missing '\end_inset'-tag in InsetSpaceParams::read. Got  
> > instead. Line: 0
> >
> > This is independent from your patch and also not from the original
> > implementation. I suspect it is a result of André's Lexer work.
>
> Other fill trouble independent of the patch: A fill at the end of the
> line will not fill to the end of line in the main window, instead a very
> narrow fill is displayed. But latex *will* fill to the end of the line.
> (Simple testcase: file->new, type "a" followed by a dotfill, view->dvi)
> This is a longstanding small problem, the old insert->hfill worked like
> that too, but it wasn't noticeable because \hfill is completely blank so
> you can't see if a hfill at the end of a paragraph does anything. A
> dotfill shows this clearly.

Yes, this has changed sometimes in 1.5svn IIRC. I don't know if it's an 
intended change, but I find it rather irritating as well.

Jürgen

Reply via email to