Bo Peng wrote:
my concern is - in case user will not use bundling feature at all, on
what places can bubble up bugs caused by embeding code. only InsetBibtex
usage? what kind of bugs?
The bugs are related to latex output, which only show up in
InsetBibtex right now.
The bugs also affect(ed?) the use of InsetCitation. (i) Create a LyX
file; (ii) insert a bibliography, selecting one of the bibfiles given on
the list (which LyX gets from $BIBINPUTS); (iii) try to insert a
citation; (iv) note that there are no citations from which to choose;
(v) wonder what the !(*& is going on.
As I have said, the bugs themselves are easy to
fix but we disagreed on how to fix them. Note that for a new feature
of this scale, I certainly expect a lot of bugs to be found and fixed.
Using a few bugs to accuse the current implementation is pointless.
I think it's pretty clear that such bugs exist in every other inset
that's involved in bundling, and for the same sort of reason. But it's
not the specific bugs that bother me. All code has bugs. What bothers me
is the fact that the bundling stuff is causing bugs even when bundling
isn't in use. This seems like a failure of encapsulation. And it seems
like more of the same to suggest fixing these bugs by making changes in
the EmbeddedFiles code. The EmbeddedFiles code should not have affected
the unbundled use of InsetCitation in the first place unless absolutely
necessary. And there is just no way that is absolutely necessary.
In the unbundled mode, I do not expect many problems caused by the
embedding code.
As I've been saying, we already have such bugs. And the EmbeddedFiles
code is so heavily entwined with the other code that I don't know how we
could be sure there won't be lots more.
Richard
