Bo Peng wrote:
I thought we'd also agreed that you don't need an EmbeddedFileList, because
you don't need any of its methods, etc, etc (and my sense is that it'd be
disastrous to call them). So what you want is just a vector<EmbeddedFile>.

Yes, but I do not see a difference if you do not call the methods.

The difference is that the methods are there to be called. It seems to me bad programming practice to use an object like this and then put in a comment that says, "Please do not call any of this object's methods!"
But I thought we'd also agreed that there may be reason not to use a vector
here but instead a map, reasons that have to do with the bibfilesCache_
(unless you want to build the map as needed). But a map is no good for the
parameters, because order matters. Etc, etc, all as discussed before.

Agreed, except that order is not a big problem, and as you have
suggested to sort embedded files, we can also sort user bibfiles. (I
know it is not particularly nice to reorganize user input :-).

You can break compilation this way. InsetBibtex needs to preserve the order.

rh

Reply via email to